add deployment.keys.<name>.name #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
force-pushed
the
key
branch
2 times, most recently
from
0700d3d
to
e5c784b
Compare
cole-h
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Beat me to it!
Tried this out locally (from master-ish), and it works as expected.
Example output:
scadrial> copying closure...
cosmere> closures copied successfully
scadrial> uploading key ‘secret-foo’ to ‘/run/keys/secret-bar’...
scadrial> stopping the following units: home-manager-vin.service
scadrial> activating the configuration...
scadrial> setting up /etc...
scadrial> reloading user units for root...
scadrial> reloading user units for vin...
scadrial> setting up tmpfiles
scadrial> starting the following units: home-manager-vin.service
scadrial> the following new units were started: libvirtd.service
scadrial> activation finished successfully
cosmere> deployment finished successfully
allows multiple keys to have the same name
With the addition of `deployment.keys.<name>.name` it's increasingly likely to make a mistake and list the same path multiple times in a deployment, leading to a race when uploading keys.
|
This is a great addition, however it increases the likelihood that you're going to have multiple keys pointing to the same path. I took the liberty of rebasing and adding a uniqueness constraint for paths in b5aebad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows multiple keys to have the same name
I haven't tested these changes against the master branch because I'm using nixops 1.7 currently. But similar changes work against 1.7.