Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blas/Lapack cross fixes #92412

Merged
merged 3 commits into from Aug 15, 2020
Merged

Blas/Lapack cross fixes #92412

merged 3 commits into from Aug 15, 2020

Conversation

matthewbauer
Copy link
Member

Cross compilation fixes for blas/lapack

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
cc-wrapper: set FC when langFortran is on
f42aa7e 
We need to set FC so that CMake and other tools can find the fortran
compiler. Also we need to limit the hardening flags since fortify and
format don’t work with fortran.

Fixes NixOS#88449
@matthewbauer
blas: use $NM instead of nm
e7ea3de 
This is the right one on cross compilation.
@matthewbauer
arpack: add blas, lapack to library path
8a525d6 
Fixes NixOS#89215
@ofborg ofborg bot requested review from Synthetica9, peti, veprbl and ttuegel July 6, 2020 05:39
@matthewbauer matthewbauer changed the base branch from master to staging July 6, 2020 16:27
@ofborg ofborg bot requested a review from ttuegel July 6, 2020 17:30
Ericson2314
Ericson2314 reviewed Jul 7, 2020
View reviewed changes
pkgs/build-support/cc-wrapper/fortran-hook.sh
Comment on lines +6 to +9
# If unset, assume the default hardening flags.
# These are different for fortran.
: ${NIX_HARDENING_ENABLE="stackprotector pic strictoverflow relro bindnow"}
export NIX_HARDENING_ENABLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fortran-specific?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - fortify & format don't work well in fortran. it's non-fatal, but we shouldn't need to set it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this is kind of an issue since it does effect cc/c++ as well

@FRidh FRidh merged commit d59c57f into NixOS:staging Aug 15, 2020
@LunNova LunNova mentioned this pull request Oct 13, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 left review comments

@ttuegel ttuegel ttuegel approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@peti peti Awaiting requested review from peti

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @ttuegel @Ericson2314 @FRidh