-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mean apsides and minimal distance #2625
Mean apsides and minimal distance #2625
Conversation
@@ -138,6 +147,10 @@ class OrbitalElements { | |||
MassiveBody const& primary, | |||
Body const& secondary); | |||
|
|||
template<typename PrimaryCentred> | |||
static std::vector<Length> Distances( | |||
DiscreteTrajectory<PrimaryCentred> const& trajectory); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Distances
is about as uninformative as it gets; make it DistancesFromPrimary
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RadialDistances
, and clarified periapsis_distance
(as opposed to altitude).
astronomy/orbital_elements.hpp
Outdated
|
||
std::vector<EquinoctialElements> osculating_equinoctial_elements_; | ||
std::vector<Length> distances_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distances_from_primary_
.
astronomy/orbital_elements.hpp
Outdated
Time sidereal_period_; | ||
std::vector<EquinoctialElements> mean_equinoctial_elements_; | ||
std::vector<ClassicalElements> mean_classical_elements_; | ||
Time anomalistic_period_; | ||
Time nodal_period_; | ||
AngularFrequency nodal_precession_; | ||
|
||
Interval<Length> distance_interval_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distances_from_primary_interval_
.
(lowest_distance - primary?.Radius)?.FormatAltitude()); | ||
double? lowest_primary_altitude = | ||
primary?.ocean == true ? 0 : primary?.pqsController?.radiusMin; | ||
string altitude_warning = lowest_distance < lowest_primary_altitude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in this comparison if one (or both) of the distances doesn't have a value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false
.
@@ -178,6 +178,9 @@ message OrbitalElements { | |||
required Interval mean_inclination = 7; | |||
required Interval mean_longitude_of_ascending_nodes = 8; | |||
required Interval mean_argument_of_periapsis = 9; | |||
required Interval mean_periapsis = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment before this line:
// Added in Gallai.
This reverts commit 3283555.
|
Add the following to the orbit analysis window:
While the mean periapsis and apoapsis altitudes are not really directly meaningful, since it is customary to describe orbits by their periapsis and apoapsis altitudes, they are a more readily understood description of the size and shape of the orbit.