bash-bd: init at 1.02 #92325
Closed
bash-bd: init at 1.02 #92325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with Please rename your PR title with: |
SuperSandro2000
requested changes
Nov 29, 2020
| src = fetchFromGitHub { | ||
| owner = "vigneshwaranr"; | ||
| repo = "bd"; | ||
| rev = "c497fe7d85ec13e75c087a0fc64e67eeb4a24b0c"; |
There was a problem hiding this comment.
Suggested change
| rev = "c497fe7d85ec13e75c087a0fc64e67eeb4a24b0c"; | |
| rev = "v${version}"; |
| maintainers = [ stdenv.lib.maintainers.adamse ]; | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove the final new line.
Comment on lines
+22
to
+29
| meta = { | ||
| description = "Quickly go back to a specific parent directory in bash instead of typing `cd ../../..` redundantly"; | ||
| homepage = "https://github.com/vigneshwaranr/bd"; | ||
| license = stdenv.lib.licenses.mit; | ||
|
|
||
| platforms = stdenv.lib.platforms.unix; | ||
| maintainers = [ stdenv.lib.maintainers.adamse ]; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = { | |
| description = "Quickly go back to a specific parent directory in bash instead of typing `cd ../../..` redundantly"; | |
| homepage = "https://github.com/vigneshwaranr/bd"; | |
| license = stdenv.lib.licenses.mit; | |
| platforms = stdenv.lib.platforms.unix; | |
| maintainers = [ stdenv.lib.maintainers.adamse ]; | |
| }; | |
| meta = with lib; { | |
| description = "Quickly go back to a specific parent directory in bash instead of typing `cd ../../..` redundantly"; | |
| homepage = "https://github.com/vigneshwaranr/bd"; | |
| license = stdenv.lib.licenses.mit; | |
| platforms = platforms.unix; | |
| maintainers = with maintainers; [ adamse ]; | |
| }; |
|
@adamse could you address the changes suggested by @SuperSandro2000 |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)