Skip to content

libxml2: fix python2 build on darwin #92347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

libxml2: fix python2 build on darwin #92347

merged 1 commit into from
Jul 9, 2020
+2 −1

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jul 5, 2020 •
edited by marsam
Loading

Motivation for this change

Fixes #91414

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 5, 2020
@ofborg ofborg bot requested a review from edolstra July 5, 2020 15:59
@dhess
Copy link
Contributor

dhess commented Jul 7, 2020

Is this ready to merge?

@LnL7
Copy link
Member Author

LnL7 commented Jul 7, 2020

It should be, this also fixes the problem you where running into right?

@dhess
Copy link
Contributor

dhess commented Jul 9, 2020

Yes, I can confirm this fixes the issue I'm having. Thanks!

@LnL7 LnL7 merged commit e0604a9 into NixOS:master Jul 9, 2020
@LnL7 LnL7 deleted the darwin-libxml2 branch July 9, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to build libxml2 in latest macos
2 participants
@LnL7 @dhess