Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endgame singularity/1.00 #92346

Merged
merged 2 commits into from Jul 5, 2020
Merged

Endgame singularity/1.00 #92346

merged 2 commits into from Jul 5, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 5, 2020

Motivation for this change

A long-awaited release! As a bonus, I added an option to disable the music pack.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fgaz added 2 commits July 5, 2020 17:29
@fgaz
endgame-singularity: 0.30c -> 1.00
d80eeae
@fgaz
endgame-singularity: add option to disable the default music pack
c823b4c 
It's the heaviest part of the game. People may not want to have it take
space or may want to use their own music.
@fgaz
Copy link
Member Author

fgaz commented Jul 5, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 5, 2020
@fgaz
Copy link
Member Author

fgaz commented Jul 5, 2020

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot requested a review from ryantm July 5, 2020 16:09
@ryantm ryantm merged commit c09177d into NixOS:master Jul 5, 2020
@fgaz fgaz deleted the endgame-singularity/1.00 branch July 5, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @ryantm