Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snes9x-gtk: fix GSettings crash when opening file picker #92364

Closed
wants to merge 1 commit into from
Closed

snes9x-gtk: fix GSettings crash when opening file picker #92364

wants to merge 1 commit into from

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Without this, when pressing the "Open ROM Image" button, the application crashes:

(snes9x-gtk:30675): GLib-GIO-ERROR **: 21:05:41.941: No GSettings schemas are installed on the system
zsh: trace trap (core dumped)  snes9x-gtk

Issue seems to have gotten introduced with this commit.

This makes it impossible to pick a ROM, so the application is essentially useless. When adding wrapGAppsHook back as a nativeBuildInput, the issue doesn't seem to occur anymore. Not sure why this was removed in the first place.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from qknight July 5, 2020 19:16
danielfullmer
danielfullmer approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for breaking this. I must have mistakenly removed this.

I didn't have any problem on my machine while testing, even without wrapGAppsHook, presumably because the gsettings are included in my environment elsewhere. I can, however, reproduce the issue using nix-shell --pure.

LGTM

@IvarWithoutBones
Copy link
Member Author

Anything blocking this from getting merged?

@Lassulus
Copy link
Member

Lassulus commented Aug 20, 2020 •
edited

well now a conflict stops this from being merged

@IvarWithoutBones
Copy link
Member Author

Looks like this was fixed already: bfac207

@IvarWithoutBones IvarWithoutBones deleted the snes9x-fix branch September 3, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfullmer danielfullmer danielfullmer approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @Lassulus @danielfullmer