Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [CMake] Re-enable multi-threaded compilation for MSVC project files #8265

Merged
merged 1 commit into from Jul 5, 2020
Merged

Fix: [CMake] Re-enable multi-threaded compilation for MSVC project files #8265

merged 1 commit into from Jul 5, 2020

Conversation

michicc
Copy link
Member

@michicc michicc commented Jul 5, 2020

No description provided.

@nielsmh
Copy link
Contributor

nielsmh commented Jul 5, 2020

This only affects builds via MSBuild of generated VCXProj files, and not Ninja-based builds, right?

@michicc
Copy link
Member Author

michicc commented Jul 5, 2020

As far as I know yes.

nielsmh
nielsmh approved these changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and should at least speed up the CI build.

@michicc michicc merged commit de4dc79 into OpenTTD:master Jul 5, 2020
@michicc michicc deleted the pr/cmake_msvc_mp branch July 5, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsmh nielsmh nielsmh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @nielsmh