Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/common/acme/server/*: use X.509 v3 certificate #92322

Closed
wants to merge 1 commit into from
Closed

nixos/tests/common/acme/server/*: use X.509 v3 certificate #92322

wants to merge 1 commit into from

Conversation

typetetris
Copy link
Contributor

@typetetris typetetris commented Jul 5, 2020 •
edited

Motivation for this change

Some client tls libraries don't accept the server certificate if it isn't a X509 v3 certificate.

I wrote some tests for a library which need that. I want to upstream them eventually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests). I did rg -li snakeoil in nixos/tests and run all those:
    • nixos/tests/systemd-networkd-vrf.nix
    • nixos/tests/openssh.nix
    • nixos/tests/prometheus.nix
    • nixos/tests/grafana.nix
    • nixos/tests/sanoid.nix
    • nixos/tests/openstack-image.nix
    • nixos/tests/taskserver.nix
    • nixos/tests/prometheus-exporters.nix
    • nixos/tests/nix-ssh-serve.nix
    • nixos/tests/ec2.nix
    • nixos/tests/pam-oath-login.nix
    • nixos/tests/gitea.nix
    • nixos/tests/codimd.nix
    • nixos/tests/buildkite-agents.nix
    • nixos/tests/matrix-synapse.nix
    • nixos/tests/xandikos.nix
    • nixos/tests/google-oslogin/default.nix
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@typetetris
nixos/tests/common/acme/server/*: use X.509 v3 certificate
d3d51bb 
some tls clients don't accept the server certificate,
if it isn't a X509 v3 certificate.
@typetetris typetetris requested a review from aszlig July 5, 2020 16:48
@typetetris
Copy link
Contributor Author

codimd.nix just hangs, ec2.nix and google-oslogin/default.nix fail with errors seemingly unrelated to the certificate change.

@aszlig
Copy link
Member

aszlig commented Jul 7, 2020

@typetetris: Those tests don't even use the acme module or did I miss something here?

@typetetris
Copy link
Contributor Author

typetetris commented Jul 7, 2020 •
edited

@typetetris: Those tests don't even use the acme module or did I miss something here?

I actually don't know, those files just contain the word snakeoil, so I did run them.

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@typetetris
Copy link
Contributor Author

Not needed any more.

@typetetris typetetris closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@typetetris @aszlig @ryantm