nixos/tests/common/acme/server/*: use X.509 v3 certificate #92322
+165
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some tls clients don't accept the server certificate, if it isn't a X509 v3 certificate.
ofborg
bot
added
6.topic: nixos
|
|
|
@typetetris: Those tests don't even use the acme module or did I miss something here? |
aszlig
approved these changes
Jul 7, 2020
I actually don't know, those files just contain the word snakeoil, so I did run them. |
ryantm
added
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Not needed any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some client tls libraries don't accept the server certificate if it isn't a X509 v3 certificate.
I wrote some tests for a library which need that. I want to upstream them eventually.
Things done
sandboxinnix.confon non-NixOS linux)rg -li snakeoilinnixos/testsand run all those:nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)