Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 973aeb046625
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c34507d795fa
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jun 19, 2020

  1. nixos-install: error out if $mountPoint has bad permissions 

    The nix store more-or-less requires o+rx on all parent directories.
This is primarily because nix runs builders in a uid/gid mapped
user-namespace, and those builders have to be able to operate on the nix
store.

This check is especially helpful because nix does not produce a helpful
error on its own (rather, creating directories and such works, it's not
until 'mount --bind' that it gets an EACCES).

Helps users who run into this opaque error, such as in #67465.
Possibly fixes that issue if bad permissions were the only cause.
    @euank
    euank committed Jun 19, 2020
    Copy the full SHA
    460c0d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2020

  1. Merge pull request #90431 from euank/nixos-install-warn 

    nixos-install: error out if $mountPoint has bad permissions
    @matthewbauer
    matthewbauer committed Jul 5, 2020
    Copy the full SHA
    c34507d View commit details
    Browse the repository at this point in the history