Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pypubsub: init at 4.0.3 #92385

Merged
merged 2 commits into from Jul 8, 2020
Merged

python3Packages.pypubsub: init at 4.0.3 #92385

merged 2 commits into from Jul 8, 2020

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Jul 5, 2020 •
edited

Motivation for this change

Add PyPubSub to NixOS. It'll necessary when packagin wxPython 4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfmoraes tfmoraes force-pushed the pypubsub-4.0.3 branch 3 times, most recently from 185bd52 to 65c48f5 Compare July 6, 2020 00:21
jonringer
jonringer reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

maintainers/maintainer-list.nix Show resolved Hide resolved
jonringer
jonringer reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

builder for '/nix/store/yh9v8ckwagz58ibmr6fr79k9rb2my2ms-python2.7-pypubsub-4.0.3.drv' failed with exit code 1; last 10 log lines:
  adding 'Pypubsub-4.0.3.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/source/dist /build/source
  DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
  Processing ./Pypubsub-4.0.3-py2-none-any.whl
  ERROR: Package 'Pypubsub' requires a different Python: 2.7.18 not in '>=3.3, <4'
  builder for '/nix/store/yh9v8ckwagz58ibmr6fr79k9rb2my2ms-python2.7-pypubsub-4.0.3.drv' failed with exit code 1
cannot build derivation '/nix/store/320rypwdvf6mhq27ch19rx77121013h7-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 1 copied (0.5 MiB), 0.0 MiB DL]
error: build of '/nix/store/320rypwdvf6mhq27ch19rx77121013h7-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/92385
1 package failed to build:
python27Packages.pypubsub

2 packages built:
python37Packages.pypubsub python38Packages.pypubsub

pkgs/development/python-modules/pypubsub/default.nix Show resolved Hide resolved
pkgs/development/python-modules/pypubsub/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

please run nixpkgs-review on your PR, it's usually required for new package additions

@tfmoraes
Copy link
Contributor Author

tfmoraes commented Jul 7, 2020

Done. The output of nixpkgs-review is:

❯ nix-shell -p nixpkgs-review --run "nixpkgs-review rev 37a5f2452b6225b15016e7798c3c484a8b8d22dc"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (14/14), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 8 (delta 6), reused 5 (delta 4), pack-reused 0
Unpacking objects: 100% (8/8), 1.35 KiB | 98.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   2603a6d8bef..3b4e26b4e38  master     -> refs/nixpkgs-review/0
$ git worktree add /home/thiago/.cache/nixpkgs-review/rev-37a5f2452b6225b15016e7798c3c484a8b8d22dc-1/nixpkgs 3b4e26b4e3881ecd3cde77b31818b48b27c55e75
Preparing worktree (detached HEAD 3b4e26b4e38)
HEAD is now at 3b4e26b4e38 Merge pull request #92606 from aanderse/perl-packages/beanstalk-client
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-37a5f2452b6225b15016e7798c3c484a8b8d22dc-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 37a5f2452b6225b15016e7798c3c484a8b8d22dc
Auto-merging pkgs/top-level/python-packages.nix
Auto-merging maintainers/maintainer-list.nix
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-37a5f2452b6225b15016e7798c3c484a8b8d22dc-1/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
python37Packages.pypubsub (init at 4.0.3) python38Packages.pypubsub (init at 4.0.3)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/rev-37a5f2452b6225b15016e7798c3c484a8b8d22dc-1/build.nix
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
2 packages built:
python37Packages.pypubsub python38Packages.pypubsub

$ nix-shell /home/thiago/.cache/nixpkgs-review/rev-37a5f2452b6225b15016e7798c3c484a8b8d22dc-1/shell.nix

jonringer
jonringer approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92385 1

1 package failed to build: - python27Packages.pypubsub
2 packages built: - python37Packages.pypubsub - python38Packages.pypubsub

@jonringer jonringer merged commit cfd78fd into NixOS:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfmoraes @jonringer