Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hglib: re-enable test_merge_prompt_cb #92310

Merged
merged 1 commit into from Jul 5, 2020
Merged

pythonPackages.hglib: re-enable test_merge_prompt_cb #92310

merged 1 commit into from Jul 5, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 5, 2020

This was resolved since ea18da4 ('mercurial: 5.3 -> 5.3.1')

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
pythonPackages.hglib: re-enable test_merge_prompt_cb
72f619f 
This was resolved since ea18da4 ('mercurial: 5.3 -> 5.3.1')
@ofborg ofborg bot requested a review from dfoxfranke July 5, 2020 05:45
@veprbl
Copy link
Member Author

veprbl commented Jul 5, 2020

@GrahamcOfBorg build python27Packages.hglib
@GrahamcOfBorg build python37Packages.hglib
@GrahamcOfBorg build python38Packages.hglib

@veprbl veprbl merged commit 3c453ad into NixOS:master Jul 5, 2020
@veprbl veprbl deleted the pr/hglib_reenable_test branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dfoxfranke dfoxfranke Awaiting requested review from dfoxfranke

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl