Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: Fix invalid link reference in release notes #92350

Merged
merged 1 commit into from Jul 5, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jul 5, 2020

Motivation for this change

Fix NixOS manual build failure introduced by #83104.

vp2rmnc0cagd9g8yz9hw30m78g3q35fb-nixos-manual-combined.drv
manual-combined.xml:82287: element link: validity error : IDREF attribute linkend references an unknown ID "opt-nix.buildMachine"
 82283       </para>
 82284     </listitem>
 82285     <listitem>
 82286      <para>
 82287       The <link linkend="opt-nix.buildMachine">nix.buildMachine</link> option is now type-checked.
 82288       There are no functional changes, however this may require updating some configurations to use correct types for all attributes.
 82289      </para>

manual-combined.xml fails to validate
Things done
  • Tested with nix build -f ./nixos --arg configuration '{ config = { fileSystems."/".fsType = "tmpfs"; boot.loader.systemd-boot.enable = true; };}' system`
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @Valodim @Ericson2314

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Thanks.

@vcunat vcunat merged commit ad12c12 into NixOS:master Jul 5, 2020
@Valodim
Copy link
Contributor

Valodim commented Jul 5, 2020

Oop, that one slipped through. Thanks for the fix!

@B4dM4n B4dM4n deleted the release-notes-fix branch July 6, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants