Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: [CMake] Source group definitions for MSVC project filters. #8264

Merged
merged 1 commit into from Jul 10, 2020
Merged

Add: [CMake] Source group definitions for MSVC project filters. #8264

merged 1 commit into from Jul 10, 2020

Conversation

michicc
Copy link
Member

@michicc michicc commented Jul 5, 2020

I kinda liked the logical grouping of the source files in the old MSVC project. This commit restores this grouping in the generated project files.

I tried adding the source_group definitions to the appropriate CMakeLists, but apparently this just doesn't work: https://stackoverflow.com/questions/31422680/how-to-set-visual-studio-filters-for-nested-sub-directory-using-cmake

@michicc
Add: [CMake] Source group definitions to create file filters in gener…
9f60979 
…ated project files (like the old MSVC projects).
@LordAro
Copy link
Member

LordAro commented Jul 5, 2020

Maybe add a comment about using source_group(TREE ...) for when we upgrade to 3.8 ? (Or just upgrade to 3.8 anyway?)

@michicc
Copy link
Member Author

michicc commented Jul 5, 2020

I have CMake 3.17 locally here and I wasn't able to get anything useful out of TREE. I just might be too dumb for it though...

LordAro
LordAro approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, I think having the filters all defined in one place might actually be better than having work out how the various regexes cascade together if they were in all sorts of separate files.

@michicc michicc merged commit 00eccbe into OpenTTD:master Jul 10, 2020
@michicc michicc deleted the pr/cmake_msvc_filter branch July 10, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @LordAro