Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzzel #92390

Merged
merged 4 commits into from Jul 8, 2020
Merged

Add fuzzel #92390

merged 4 commits into from Jul 8, 2020

Conversation

fionera
Copy link
Member

@fionera fionera commented Jul 6, 2020

Motivation for this change

Adding fuzzel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 6, 2020

Also the commit messages should be named:

  • maintainers: add fionera
  • fuzzel: init at 1.3.0

@fionera fionera force-pushed the add-fuzzel branch 2 times, most recently from 9123856 to 3a2118c Compare July 6, 2020 03:17
@fionera
Copy link
Member Author

fionera commented Jul 6, 2020

Changes are all done now :)

jtojnar
jtojnar reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like an old version of fcft is used but it looks like newer is not supported 🤷‍♀️

Other than few nits and missing license looks good.

pkgs/applications/misc/fuzzel/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tllist/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/fcft/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fuzzel/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/fcft/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tllist/default.nix Outdated Show resolved Hide resolved
@fionera
Copy link
Member Author

fionera commented Jul 6, 2020

Ok like this?

@fionera
Copy link
Member Author

fionera commented Jul 8, 2020

Is it ok now?

@jtojnar jtojnar merged commit 143398d into NixOS:master Jul 8, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 8, 2020

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fionera @jtojnar @Janik-Haag