Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nvme to default availableKernelModules #82988

Closed
wants to merge 1 commit into from
Closed

Add nvme to default availableKernelModules #82988

wants to merge 1 commit into from

Conversation

curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Mar 20, 2020 •
edited

WIP: we're still trying to get to the bottom of this issue.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Mar 20, 2020
View reviewed changes
nixos/modules/system/boot/kernel.nix
@@ -215,6 +215,9 @@ in

# SD cards and internal eMMC drives.
"mmc_block"

# NVMe devices.
"nvme"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixos-generate-config also takes care of this usually.

@Ekleog
Copy link
Member

Ekleog commented Jul 6, 2020

Seeing the

WIP: we're still trying to get to the bottom of this issue.

I'm closing for now, feel free to reopen if/when you get to the bottom of it :)

@Ekleog Ekleog closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dasJ dasJ Awaiting requested review from dasJ dasJ will be requested when the pull request is marked ready for review dasJ is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curiousleo @Ekleog @Mic92