Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.{math-functions,mockery}: dontCheck #92374

Merged
merged 2 commits into from Jul 6, 2020
Merged

haskellPackages.{math-functions,mockery}: dontCheck #92374

merged 2 commits into from Jul 6, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 5, 2020

Motivation for this change

IIUC these are channel blockers on Darwin. @cdepillabout please let me know if this should go to haskell-updates?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from cdepillabout as a code owner July 5, 2020 20:36
@marsam marsam linked an issue Jul 5, 2020 that may be closed by this pull request
haskellPackages.math-functions fails tests on darwin #92366
Closed
@marsam
Copy link
Contributor Author

marsam commented Jul 5, 2020

@GrahamcOfBorg build cachix
@GrahamcOfBorg build pandoc

@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Jul 5, 2020
@cdepillabout
Copy link
Member

cdepillabout commented Jul 6, 2020 •
edited

@marsam Thanks for sending these.

In general, these types of PRs should go to haskell-updates, but since this is a channel blocker, I guess it is okay in master.

However, could you add some comments (and possibly report upstream?) why dontCheck is only needed on darwin?

edit: Oh, I see there is a link to an upstream issue for math-functions. Could you add the same thing for mockery?

After that, I'd be happy for this to be merged in.

@vcunat
Copy link
Member

vcunat commented Jul 6, 2020 •
edited

math-functions case has been reported upstream already; I don't think it's exactly clear why but different libc is probably what triggered this.

@marsam
Copy link
Contributor Author

marsam commented Jul 6, 2020

@GrahamcOfBorg build cachix
@GrahamcOfBorg build pandoc

@marsam marsam force-pushed the fix-cachix-build branch 2 times, most recently from 2ab66ef to f25f7eb Compare July 6, 2020 12:15
@marsam
Copy link
Contributor Author

marsam commented Jul 6, 2020

@cdepillabout sure, I added comments to each change

@GrahamcOfBorg build cachix
@GrahamcOfBorg build pandoc
@GrahamcOfBorg build haskellPackages.mockery

@cdepillabout
Copy link
Member

@marsam Thanks for adding issues pointing upstream.

This looks good now, and since it appears to be holding up the darwin channel update, I'm going to go ahead and merge it in.

cc @maralorn and @peti just so they are aware of this issue as well.

@cdepillabout cdepillabout merged commit 837e0a8 into NixOS:master Jul 6, 2020
@marsam marsam deleted the fix-cachix-build branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

haskellPackages.math-functions fails tests on darwin
3 participants
@marsam @cdepillabout @vcunat