Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake.nix: add armv6l/armv7l systems #92423

Merged
merged 1 commit into from Jul 28, 2020
Merged

flake.nix: add armv6l/armv7l systems #92423

merged 1 commit into from Jul 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 6, 2020

We built at least armv7l on hydra, therefor nixpkgs should also expose it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
flake.nix: add armv6l/armv7l systems
4c26d0e 
We built at least armv7l on hydra, therefor nixpkgs should also expose it.
@Mic92
Copy link
Member Author

Mic92 commented Jul 6, 2020

cc @GrahamcOfBorg

@vcunat
Copy link
Member

vcunat commented Jul 6, 2020 •
edited

Perhaps it's a tangent, but I don't think we had an armv7 builder on Hydra in the past few months (if I look correctly). I have no idea about (future) plans on this.

EDIT: I had disabled evaluation of that jobset after long time of generating unrunnable jobs.

@Mic92 Mic92 merged commit 55cd36a into NixOS:master Jul 28, 2020
@Mic92 Mic92 deleted the arm-flakes branch July 28, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @vcunat