Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apachePulsar: 2.6.0 #92393

Closed
wants to merge 1 commit into from
Closed

apachePulsar: 2.6.0 #92393

wants to merge 1 commit into from

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Jul 6, 2020 •
edited

Motivation for this change

This PR adds initial Nix support for Apache Pulsar, a widely used messaging system akin to Kafka, RabbitMQ, and related systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lucperkins lucperkins changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> apachePulsar: 2.6.0 Jul 6, 2020
@lucperkins
apachePulsar: 2.6.0
8bd97e1 
Signed-off-by: lucperkins <lucperkins@gmail.com>
@lucperkins
Copy link
Contributor Author

Closing this, as #91837 is a better approach IMO

@lucperkins lucperkins closed this Jul 6, 2020
@lucperkins lucperkins deleted the apache-pulsar-support branch July 6, 2020 15:59
@jlesquembre jlesquembre mentioned this pull request Mar 31, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucperkins @Janik-Haag