Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.LanguageClient-neovim: 0.1.157 -> 0.1.158 #92323

Merged
merged 1 commit into from Jul 30, 2020
Merged

vimPlugins.LanguageClient-neovim: 0.1.157 -> 0.1.158 #92323

merged 1 commit into from Jul 30, 2020

Conversation

symphorien
Copy link
Member

@symphorien symphorien commented Jul 5, 2020 •
edited

Motivation for this change

Update

Things done

Tested in neovim with rls.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member Author

/marvin opt-in
/status needs_review

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 23, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 23, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@symphorien
Copy link
Member Author

/status needs_reviewer

@Mic92 Mic92 merged commit 4701e11 into NixOS:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 marvin needs_reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @Mic92