-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
zfs: patch client path used in smb share #92378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please squash the commits together. |
Please rebase this.
|
I marked this as stale due to inactivity. → More info |
fix zfs smb share integration before: # zfs share tank/smb_share cannot share tank/smb_share: smb add share failed now works as intended.
Does this require a samba configuration? Do you have a setup to test this? |
Sure! I've updated my comment, check it out. |
Co-authored-by: jnetod <49963580+jnetod@users.noreply.github.com>
@GrahamcOfBorg test zfs.stable |
After that, PR significantly increased the size of the iso image. The image now contains the samba package, which is not needed there. |
Before PR:
After PR:
|
If it really bothers you, please create a PR which moves samba support behind a boolean flag and disables it for the iso. |
fix zfs smb share integration
before:
now works as intended.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)