Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Package.gdcm: 3.0.6 -> 3.0.7 #92377

Merged
merged 1 commit into from Jul 6, 2020
Merged

python3Package.gdcm: 3.0.6 -> 3.0.7 #92377

merged 1 commit into from Jul 6, 2020

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Jul 5, 2020

Modified GDCM package to package its Python wrapper.

Motivation for this change

Add the Python wrappers from GDCM

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jul 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should also be:

python3Package.gdcm: 3.0.6 -> 3.0.7

to conform to CONTRIBUTING.md

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gdcm/default.nix Show resolved Hide resolved
pkgs/development/libraries/gdcm/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gdcm/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented Jul 5, 2020 •
edited

thanks for opening your first PR with nixpkgs @tfmoraes

@tfmoraes
Copy link
Contributor Author

tfmoraes commented Jul 5, 2020

Hi @jonringer ! Thanks!

I needed to move "-DGDCM_INSTALL_PYTHONMODULE_DIR" to preConfigure because $out was not available inside cmakeFlags

@jonringer
Copy link
Contributor

@tfmoraes to defer bash expansion, you can use the placholder builltin.

e.g

${placeholder "out"}/${python.sitePackages}

@tfmoraes
Copy link
Contributor Author

tfmoraes commented Jul 5, 2020

Thanks @jonringer ! It worked. It's in the last commit.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages-gdcm 3.0.7

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages-gdcm

@jonringer jonringer changed the title python3Packages-gdcm 3.0.7 python3Package.gdcm: 3.0.6 -> 3.0.7 Jul 6, 2020
@tfmoraes
Copy link
Contributor Author

tfmoraes commented Jul 6, 2020

Done @jonringer

jonringer
jonringer approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/92377
2 packages failed to build:
python37Packages.dicom2nifti python38Packages.dicom2nifti

3 packages built:
gdcm python37Packages.gdcm python38Packages.gdcm

@jonringer jonringer merged commit 956d7b8 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfmoraes @jonringer @Janik-Haag