Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stabber: 2016-11-09 -> 2020-06-08 #95330

Merged
merged 1 commit into from Aug 16, 2020
Merged

stabber: 2016-11-09 -> 2020-06-08 #95330

merged 1 commit into from Aug 16, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change

I originally wanted to fix profanity build, but then realised that it does not depend on stabber anymore since #95054

Anyway this fixes the build for stabber. I also updated meta.homepage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
stabber: 2016-11-09 -> 2020-06-08
450f5fe 
Also updated meta.homepage
@ofborg ofborg bot requested a review from hschaeidt August 13, 2020 14:34
@alyssais alyssais merged commit 066544a into NixOS:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hschaeidt hschaeidt Awaiting requested review from hschaeidt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictapen @alyssais