Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rider 2020.1.4 -> 2020.2 + fix build #95333

Closed
wants to merge 3 commits into from

Conversation

BananchickPasha
Copy link
Contributor

Motivation for this change

In rider 2020.2 there is no mono backend, so old nix-build fails because it can't find lib/ReSharperHost/linux-x64/mono/bin/mono-sgen

Things done

Deleted code which patches mono

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DamienCassou
Copy link
Contributor

A similar PR has already been merged, I'm sorry: #95789. If there is anything you want to change, e.g., update to 2020.2.1, please do and CC me. I'm closing this PR for now, feel free to reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants