pythonPackages.exchangelib: removed due to prolonged breakage #95313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
8.has: clean-up
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
If something hasn't built successfully for a long time, I don't expect anyone would even notice the removal. |
|
But why not mention the maintainers: @catern |
|
I know some like to throw when software is (re)moved. I don't find showing warnings important, and I think modules can be removed without a trace. Just indeed cc the listed maintainers. |
|
Thanks for pinging me, let me give fixing it a try. |
|
Ah, I see. Well, I see no harm in trying the process including this step. |
|
I'll make a PR per removal if a maintainer is listed, otherwise I'll make another PR to remove all the unmaintained packages |
jonringer
force-pushed
the
remove-broken-py
branch
from
54013fe
to
dd475a6
Compare
catern
added a commit
to catern/nixpkgs
that referenced
this pull request
Aug 13, 2020
Also marks the package as no longer broken. Obsoletes PR NixOS#95313
10 tasks
|
Sorry for the long breakage, but it's fixed now (and upgraded to boot) |
jonringer
pushed a commit
that referenced
this pull request
Aug 13, 2020
Also marks the package as no longer broken. Obsoletes PR #95313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There's about 20 other python modules that have been broken prior to the 20.03 release.
Currently I'm just looking for feedback on what the message and convention should be for doing such removals
cc @FRidh
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)