Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Web connectivity test contains null in blocking key #867

Closed
lorenzoPrimi opened this issue Oct 19, 2016 · 5 comments
Closed

Web connectivity test contains null in blocking key #867

lorenzoPrimi opened this issue Oct 19, 2016 · 5 comments
Labels
bug

Comments

@lorenzoPrimi
Copy link
Contributor

lorenzoPrimi commented Oct 19, 2016 •
edited

When running the latest version of the NetProbe app (using mk 0.3.2) the web connectivity test contains a null key in the blocking and accessible key.

Runned with:

mk::ooni::WebConnectivity()
    .set_options("backend", "https://a.web-connectivity.th.ooni.io:4442")
    .set_options("nameserver", get_dns_server())
    .set_options("geoip_country_path", [geoip_country UTF8String])
    .set_options("geoip_asn_path", [geoip_asn UTF8String])
    .set_options("net/ca_bundle_path", [ca_cert UTF8String])
    .set_options("save_real_probe_ip", include_ip)
    .set_options("save_real_probe_asn", include_asn)
    .set_options("save_real_probe_cc", include_cc)
    .set_options("no_collector", !upload_results)
    .set_options("collector_base_url", [collector_address UTF8String])
    .set_input_filepath([path UTF8String])
    .set_output_filepath([[self getFileName:@"json"] UTF8String])
    .set_verbosity(MK_LOG_INFO)

urls.txt

http://torproject.org
http://ooni.nu
http://neubot.org
http://archive.org
http://creativecommons.org
http://cyber.law.harvard.edu
http://duckduckgo.com
http://netflix.com
http://nmap.org
http://www.emule.com
@lorenzoPrimi lorenzoPrimi changed the title Web connectivity test contains null in blocked key Web connectivity test contains null in blocking key Oct 19, 2016
bassosimone added a commit that referenced this issue Oct 21, 2016
@bassosimone
web_connectivity: set the accessible key
6c8ad26 
As reported by @lorenzoPrimi in #867, the accessible key was not
correctly set in the output JSON.

This simple diff should fix the issue by setting the accessible
key depending on whether there was blocking.

Closes #867.
@bassosimone bassosimone mentioned this issue Oct 21, 2016
Merged
@bassosimone
Copy link
Member

Thank you for reporting this bug! I've committed a hotfix in #871 and will merge it as soon as the automatic tests on travis-ci and circle-ci terminate.

bassosimone added a commit that referenced this issue Oct 21, 2016
@bassosimone
web_connectivity: set the accessible key (#871)
3bc9058 
As reported by @lorenzoPrimi in #867, the accessible key was not
correctly set in the output JSON.

This simple diff should fix the issue by setting the accessible
key depending on whether there was blocking.

Closes #867.
@bassosimone
Copy link
Member

Now #871 has been merged, so we can close this issue.

bassosimone added a commit that referenced this issue Oct 23, 2016
@bassosimone
connect.cpp: increase default net/timeout (#872)
c91bb71 
* web_connectivity: set the accessible key

As reported by @lorenzoPrimi in #867, the accessible key was not
correctly set in the output JSON.

This simple diff should fix the issue by setting the accessible
key depending on whether there was blocking.

Closes #867.

* connect.cpp: increase default net/timeout

A timeout of at least 30 seconds for connect() should be a reasonable
timeout and it should in particular be more reasonable than five seconds
given that we have seen that inactive heroku machines, for example,
take more than five seconds to respond.

This should fix the immediate bug reported in #864. I've yet to decide
whether this would also mean we can close the bug or not.
@hellais
Copy link
Contributor

hellais commented Oct 26, 2016

This is great! However I think that another fix is needed to also set the blocking key to false at the end of the if chain.

@hellais hellais reopened this Oct 26, 2016
@bassosimone
Copy link
Member

ack

@bassosimone bassosimone mentioned this issue Oct 28, 2016
Closed
4 tasks
@AntonioLangiu AntonioLangiu mentioned this issue Oct 28, 2016
Merged
@bassosimone
Copy link
Member

Should be fixed in v0.3.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bassosimone @hellais @lorenzoPrimi