grex: init at 1.1.0 #95316
Closed
grex: init at 1.1.0 #95316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Note that another pull-request is open at #76539 for the |
jonringer
reviewed
Aug 24, 2020
Comment on lines
+27
to
+28
| doCheck = false; | ||
|
|
There was a problem hiding this comment.
don't feel really strongly about this, but I can't think of another way to very that darwin works:
Suggested change
| doCheck = false; | |
| doCheck = false; | |
| doInstallCheck = true; | |
| installCheckPhase = '' | |
| $out/bin/grex --help > /dev/null | |
| ''; |
zowoq
requested changes
Aug 25, 2020
Comment on lines
+5
to
+7
| with rustPlatform; | ||
|
|
||
| buildRustPackage rec { |
There was a problem hiding this comment.
Suggested change
| with rustPlatform; | |
| buildRustPackage rec { | |
| rustPlatform.buildRustPackage rec { |
| sha256 = "1viph7ki6f2akc5mpbgycacndmxnv088ybfji2bfdbi5jnpyavvs"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig perl installShellFiles ]; |
There was a problem hiding this comment.
None of these seem to be needed.
Suggested change
| nativeBuildInputs = [ cmake pkgconfig perl installShellFiles ]; |
Comment on lines
+21
to
+24
| buildInputs = [ zlib ] | ||
| ++ stdenv.lib.optionals stdenv.isDarwin [ | ||
| libiconv darwin.apple_sdk.frameworks.Security ] | ||
| ; |
There was a problem hiding this comment.
Only Security seems to be needed.
Suggested change
| buildInputs = [ zlib ] | |
| ++ stdenv.lib.optionals stdenv.isDarwin [ | |
| libiconv darwin.apple_sdk.frameworks.Security ] | |
| ; | |
| buildInputs = stdenv.lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; |
Comment on lines
+26
to
+27
| # Some tests fail, but Travis ensures a proper build | ||
| doCheck = false; |
There was a problem hiding this comment.
The check passes on darwin and linux.
Suggested change
| # Some tests fail, but Travis ensures a proper build | |
| doCheck = false; |
|
@colemickens Can you please integrate the suggestions? Edit: I have opened #100173 because the author did not answer in almost 2 months. |
Merged
10 tasks
|
Closed by stalling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95315.
This introduces
grexto nixpkgs:apl2unixMotivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)