Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: add a section about common GPU acceleration issues #95336

Merged
merged 1 commit into from Aug 14, 2020
Merged

nixos/manual: add a section about common GPU acceleration issues #95336

merged 1 commit into from Aug 14, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 13, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from Flakebi August 13, 2020 13:45
Flakebi
Flakebi approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn’t know about the systemd-logind mechanism.
Looks good!

nixos/doc/manual/configuration/gpu-accel.xml Outdated
other::---</screen>

If you disabled (this functionality of) <command>systemd-logind</command>,
you may need to add the user to the <code>video</code> group.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add that one needs to logout and in again to apply the new groups.

Suggested change
you may need to add the user to the <code>video</code> group.
you may need to add the user to the <code>video</code> group and re-login.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I wondered if 're-login' is a proper verb, so I changed it to and log in again.

@danieldk danieldk merged commit 0c135e5 into NixOS:master Aug 14, 2020
@danieldk danieldk deleted the gpu-accel-common-issues branch August 14, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @Flakebi