nixos/rsyncd: convert module to an INI generator #95335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the ini generator is incorrect: rsyncd.conf expects to have the global settings first outside of any |
|
Excerpts from Nadrieril's message of January 27, 2022 5:28 pm:
FYI the ini generator is incorrect: rsyncd.conf expects to have the global settings first outside of any `[section]`, but this generates a `[global]` section instead. This means that settings like the port or user are not taken into account by the daemon.
Given the way `formats.ini` works I don't think we can use it at all sadly.
Man page says yes, but that could be wrong. In the worst case scenario we can
`sed` the generated output.
```
GLOBAL PARAMETERS
The first parameters in the file (before a [module] header) are the
global parameters. Rsync also allows for the use of a "[global]" mod‐
ule name to indicate the start of one or more global-parameter sections
(the name must be lower case).
```
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The rsyncd module is currently more complicated than it needs to be.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)