pythonPackages.urwid: disable tests for pythons < 3 #95339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder py2 otherwise
|
salut_a_toi seemed to be broken before because of this, but now still fails because of python2.7-wokkel-0.7.0 |
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
jonringer
reviewed
Aug 23, 2020
| @@ -9,6 +9,8 @@ buildPythonPackage rec { | |||
| sha256 = "09nmi2nmvpcmbh3w3fb0dn0c7yp7r20i5pfcr6q722xh6mp8cw3q"; | |||
| }; | |||
|
|
|||
| # tests fail in python2 | |||
| doCheck = pythonAtLeast "3.0"; | |||
There was a problem hiding this comment.
|
On 23/08/2020 20:22, Jon wrote:
do you mind adding:
```
pythonImportsCheck = [ "urwid" ];
```
and then I can close mine #96104
Actually, lets close this one and keep yours, I didn't even know about
`isPy3k`, and you seem to have a clearer idea about what was broken
around here. I saw a failure I didn't want to look up and disabled tests
as a last (and only) resort.
I did want to ask, what does pythonImportsCheck do? I _also_ didn't know
about it.
|
From my template: If tests are not available, then please use |
|
On 24/08/2020 17:58, Jon wrote:
From my template:
If tests are not available, then please use `pythonImportsCheck` to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see [pythonImportsCheck documentation](https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonimportscheck) for more information.
Interesting, thanks! I guess this proves I didn't look much into this :'D
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
python2Packages.urwid fails to build, as per #94684
Disabling tests lets it build without apparent breakage on the only package in my system that depends on it (targetcli).
I'm also opening another PR to make targetcli build with python3, which I think is preferable in any case where that's an option
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)