Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tektoncd-cli: init at 0.13.0 #95320

Merged
merged 1 commit into from Oct 22, 2020
Merged

tektoncd-cli: init at 0.13.0 #95320

merged 1 commit into from Oct 22, 2020

Conversation

mstrangfeld
Copy link
Member

@mstrangfeld mstrangfeld commented Aug 13, 2020 •
edited

Motivation for this change

The Tekton CLI is great for interacting with Tekton pipelines and should definitely be in the nixpkgs repository.

Official website: https://tekton.dev/
Git Repository: https://github.com/tektoncd/cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 13, 2020 12:22
@mstrangfeld mstrangfeld changed the title tektoncd-cli: init at 0.11.0 tektoncd-cli: init at 0.13.0 Oct 4, 2020
@06kellyjac
Copy link
Member

06kellyjac commented Oct 4, 2020 •
edited

Thanks for the PR @mstrangfeld. I've been using a similar nix expression for a while myself, tkn is quite nice to use so far!

I've made a couple of changes/suggestions on a separate branch
https://github.com/06kellyjac/nixpkgs/commits/tektoncd-cli
Feel free to cherry-pick or copy/paste any you agree with.

I've successfully installed and ran tkn version for both your branch & my changes on nixos (x86_64) and archlinux (aarch64) (I can test it on macOS too maybe later today)

If you dont mind I'd be happy to maintain this with you. I'm down in the nixpkgs maintainers file as jk

@mstrangfeld
Copy link
Member Author

Thank you for the suggestions @06kellyjac. I would be glad to have some help maintaining this. I have just copy/pasted your suggestions so this addition does not exceed one commit.

06kellyjac
06kellyjac approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/321

@06kellyjac
Copy link
Member

Result of nixpkgs-review pr 95320 1

1 package built:
  • tektoncd-cli

@06kellyjac
Copy link
Member

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/253

@AndersonTorres AndersonTorres merged commit 02e4a0e into NixOS:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@06kellyjac 06kellyjac 06kellyjac approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mstrangfeld @06kellyjac @nixos-discourse @AndersonTorres @Janik-Haag