Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spago: cli completion #95326

Merged
merged 1 commit into from Aug 25, 2020
Merged

spago: cli completion #95326

merged 1 commit into from Aug 25, 2020

Conversation

gomain
Copy link
Contributor

@gomain gomain commented Aug 13, 2020 •
edited

Motivation for this change

Install bash completion (tab completion). Following spago's documentation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gomain gomain force-pushed the spago-bash-completion branch 3 times, most recently from dbf444a to cca69c4 Compare August 14, 2020 04:22
@zowoq
Copy link
Contributor

zowoq commented Aug 22, 2020

@ofborg eval

@cdepillabout
Copy link
Member

cdepillabout commented Aug 22, 2020 •
edited

@gomain Could you instead see if haskell.lib.generateOptparseApplicativeCompletion could be used here? I think it works for most Haskell executables that are using optparse-applicative.

Also, in the future, please make sure to ping the maintainers of a package when you send a PR you want merged in.

@gomain
Copy link
Contributor Author

gomain commented Aug 24, 2020 •
edited

@gomain Could you instead see if haskell.lib.generateOptparseApplicativeCompletion could be used here? I think it works for most Haskell executables that are using optparse-applicative.

@cdepillabout Thanks for the tip.

Also, in the future, please make sure to ping the maintainers of a package when you send a PR you want merged in.

Sure.

Spago currently fails to build in master. This branch is forked off nixpkgs-unstable.

@gomain gomain changed the title spago: bash completion spago: cli completion Aug 24, 2020
@cdepillabout
Copy link
Member

This successfully builds, and the bash completion now works.

Thanks!

@cdepillabout cdepillabout merged commit 17aabf6 into NixOS:master Aug 25, 2020
@gomain gomain deleted the spago-bash-completion branch August 25, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gomain @zowoq @cdepillabout