New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinentry: 1.1.0 -> 2020-07-17 #93196
Conversation
I would like to include some logic in this package so that when ${version} = "master" then it builds from source, otherwise use the pre-defined packages. |
747324a
to
733ae48
Compare
733ae48
to
7551a04
Compare
28cc6ce
to
1a68e9f
Compare
Fixes addressed. Many thanks for the peer review |
Any further action needed for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look okay, do not see anything problematic in the upstream commits since 1.1.0: https://dev.gnupg.org/source/pinentry/history/master/
This should be rebased, instead of having master merged into it. |
b56849a
to
c37f243
Compare
cd50dff
to
4b2bce6
Compare
Squashed and rebased to recent master. Please advise further action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the commit title to pinentry: 1.1.0 -> 2020-07-17
?
cb80931
to
55de2e7
Compare
Thank you for the comments. Updated repo with suggestions |
And the branch commit history still looks messy/not squashed. |
@@ -57,7 +60,6 @@ pinentryMkDerivation rec { | |||
dontWrapQtApps = true; | |||
|
|||
patches = [ | |||
./autoconf-ar.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acd0858
to
fc72c90
Compare
fc72c90
to
8861386
Compare
I marked this as stale due to inactivity. → More info |
Superseeded by #143120. |
(Support for pinentry-efl. Pinentry 1.1.0 relase from 2017, without a
recent tagged release)
Motivation for this change
Pinentry hasn't seen an update to its release since 2017, however there has been quite a bit of development, including an addition of pinentry-efl for Elementary toolkit DEs like enlightenment. This change rebuilds pinentry from MASTER and includes
pinentry-efl
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)