Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-modemmanager-exporter: init at 0.1.0, add NixOS module #93291

Merged
merged 2 commits into from Jul 17, 2020
Merged

prometheus-modemmanager-exporter: init at 0.1.0, add NixOS module #93291

merged 2 commits into from Jul 17, 2020

Conversation

mdlayher
Copy link
Member

Motivation for this change

New Prometheus exporter for pulling cellular modem statistics from ModemManager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

PR structure inspired by my previous PR to add my Elgato Key Light exporter: #89810

Assuming a similar group of folks will likely review this, I'll tag the same folks from last time:

/cc @zowoq @Ma27 @WilliButz @mmilata

@mdlayher
prometheus-modemmanager-exporter: init at 0.1.0
703c75f 
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher mdlayher requested a review from WilliButz as a code owner July 16, 2020 18:40
@mdlayher
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.modemmanager

@ofborg ofborg bot requested a review from kalbasit July 16, 2020 18:58
@mdlayher
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.modemmanager

@mdlayher
nixos/prometheus-modemmanager-exporter: new module
a58346a 
Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.modemmanager

@WilliButz WilliButz merged commit c8a29f6 into NixOS:master Jul 17, 2020
@mdlayher mdlayher deleted the mdl-mmexporter branch July 17, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdlayher @WilliButz