azuredatastudio: 1.17.1 -> 1.20.0 #93292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Nov 29, 2020
| @@ -0,0 +1,18 @@ | |||
| [Desktop Entry] | |||
There was a problem hiding this comment.
Please use the appropriate function to create this file and place it inline with the default.nix.
|
|
||
| src = fetchurl { | ||
| url = "https://azuredatastudiobuilds.blob.core.windows.net/releases/${version}/azuredatastudio-linux-${version}.tar.gz"; | ||
| sha256 = "0px9n9vyjvyddca4x7d0zindd0dim7350vkjg5dd0506fm8dc38k"; | ||
| url = "https://sqlopsbuilds.azureedge.net/stable/cfbadd1eaef2dfa1fd643009c572137c704f1009/azuredatastudio-linux-${version}.tar.gz"; |
There was a problem hiding this comment.
Is there a stable url which we could use?
| @@ -60,7 +60,7 @@ stdenv.mkDerivation rec { | |||
| ]; | |||
|
|
|||
| # this will most likely need to be updated when azuredatastudio's version changes | |||
| sqltoolsservicePath = "${targetPath}/resources/app/extensions/mssql/sqltoolsservice/Linux/2.0.0-release.56"; | |||
| sqltoolsservicePath = "${targetPath}/resources/app/extensions/mssql/sqltoolsservice/Linux/3.0.0-release.4"; | |||
There was a problem hiding this comment.
Add a comment next to version to check this with each update.
|
Result of 1 package built:
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Azure Data Studio needed updated, and a .desktop file created.
Things done
Updated azure data studio to 1.20.0 and added a .desktop file.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)