Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.18.5 -> 1.18.6 #93223

Merged
merged 1 commit into from Jul 16, 2020
Merged

kubernetes: 1.18.5 -> 1.18.6 #93223

merged 1 commit into from Jul 16, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 16, 2020 •
edited

CVE-2020-8557 and CVE-2020-8559 among other, regular changes

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

@ofborg test kubernetes.rbac.singlenode kubernetec.rbac.multinode kubernetes.dns.singlenode kubernetes.dns.multinode

@srhb srhb changed the title k8s: 1.18.5 -> 1.18.6 kubernetes: 1.18.5 -> 1.18.6 Jul 16, 2020
@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

@ofborg test kubernetes.rbac.singlenode kubernetec.rbac.multinode kubernetes.dns.singlenode kubernetes.dns.multinode

saschagrunert
saschagrunert approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot requested a review from saschagrunert July 16, 2020 06:46
@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

Ran the tests locally and tried to fix ofborg being able to in the future on master in #93228

@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

@saschagrunert Appreciate the speediness 😁

@srhb srhb merged commit 07f38f7 into NixOS:master Jul 16, 2020
@srhb srhb deleted the k8s-1.18.6 branch July 16, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@johanot johanot Awaiting requested review from johanot

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @saschagrunert