Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoneminder: 1.34.9 -> 1.34.16 #93192

Merged
merged 2 commits into from Jul 16, 2020
Merged

zoneminder: 1.34.9 -> 1.34.16 #93192

merged 2 commits into from Jul 16, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jul 15, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peterhoeg July 15, 2020 17:12
@peterhoeg
Copy link
Member

While at it, can I trouble you to remove me as a maintainer? I haven't used ZM in ages.

@adisbladis
Copy link
Member Author

@peterhoeg Removed as requested.

Out of curiousity: Did you switch CCTV software to something else? I haven't started using zoneminder yet but I will do a CCTV setup in the next couple of days.

@adisbladis adisbladis merged commit 680c25c into NixOS:master Jul 16, 2020
@peterhoeg
Copy link
Member

I did switch, yes. motioneye is perfectly fine for my needs. ZM is just a mess IMHO.

@bachp
Copy link
Member

bachp commented Aug 8, 2020

@peterhoeg Do you have motioneye working on NixOS?

@peterhoeg
Copy link
Member

@bachp, I do yes, but not upstream and not modularized either so tied pretty heavily to my setup here. I have created a gist with the package as well as the config here: https://gist.github.com/peterhoeg/01fe3ccb54cea4d9a437b9e8ffb3c55c

There are some hardcoded ids/passwords in there but everything is on a separate VLAN without any internet access, so that should be fine (besides, those are just default passwords anyway).

@peterhoeg
Copy link
Member

One external password was not blanked out but it's been changed now and shouldn't have been in there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @peterhoeg @bachp