Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openrazer: 2.7.0 -> 2.8.0 #93275

Merged
merged 1 commit into from Jul 25, 2020
Merged

openrazer: 2.7.0 -> 2.8.0 #93275

merged 1 commit into from Jul 25, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jul 16, 2020

Motivation for this change

v2.8.0 Changelog
Support for several new devices added

Unsure if related to #92959 but figured it can/should be updated, anyway.

Things done

Bumped from 2.7.0 -> 2.8.0

cc @Algram

@Algram
Copy link
Member

Algram commented Jul 16, 2020

I would like to check if this changes fixes my problem. How would I best test this locally before the merge?

Thanks!

@evanjs
Copy link
Member Author

evanjs commented Jul 16, 2020

I would like to check if this changes fixes my problem. How would I best test this locally before the merge?

Thanks!

I'm lazy and typically use gh for checking out PRs
e.g. nix run nixos.gitAndTools.gh --command gh pr checkout 93275 from a local nixpkgs repo
That aside, from the root of a local nixpkgs repository (with the PR checked out), one way is to run nixos-rebuild switch -I nixpkgs=.

This should rebuild your system with the main channel referencing the local nixpkgs repo instead.

There are probably better ways to do it, but this is how I currently test module updates.

@Algram
Copy link
Member

Algram commented Jul 16, 2020

Thanks! I tested it and it works on my end. The mouse gets recognized and I can communicate with it via DBUS.

Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (I have the same diff I was about to PR, that I'm currently running on my workstation)

@evanjs
Copy link
Member Author

evanjs commented Jul 25, 2020

Curious, any other (Open)Razer users with merge/write permissions [for nixpkgs]?

Not sure what else I can do (or who would be best to ping) aside from e.g.
@GrahamcOfBorg build openrazer-daemon
or etc

@infinisil infinisil merged commit 883af84 into NixOS:master Jul 25, 2020
@evanjs evanjs deleted the openrazer/2.8.0 branch July 25, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants