Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redis: systemd sandbox #93277

Closed
wants to merge 3 commits into from
Closed

nixos/redis: systemd sandbox #93277

wants to merge 3 commits into from

Conversation

tnias
Copy link
Contributor

@tnias tnias commented Jul 16, 2020

Motivation for this change

Add systemd service sandbox features and improve service description.

Things done
  • Run redis service
  • Test with rspamd. Connected via tcp on localhost and unix socket.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tnias
nixos/redis: improve description
427d2f9
@tnias
nixos/redis: add systemd service sandbox
37762e4 
Also change logfile example to match the default systemd service
LogsDirectory location for redis.
@tnias
Copy link
Contributor Author

tnias commented Jul 16, 2020

cc redis maintainers @berdario @globin

@hmenke hmenke mentioned this pull request Jul 17, 2020
Draft
11 tasks
@symphorien symphorien mentioned this pull request Aug 26, 2020
Merged
11 tasks
@stale
Copy link

stale bot commented Jan 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 16, 2021
@tnias
Copy link
Contributor Author

tnias commented Jan 26, 2021

This patchset would need some fixing.

Note: AmbientCapabilities = []; is not equal to AmbientCapabilities = "";.

@tnias tnias closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tnias