Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protonvpn-gui: init at 2.1.1 #93276

Merged
merged 2 commits into from Aug 18, 2020
Merged

protonvpn-gui: init at 2.1.1 #93276

merged 2 commits into from Aug 18, 2020

Conversation

offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented Jul 16, 2020 •
edited

Motivation for this change

Package protonvpn-gui, so i can have nice graphical interface and tray to connect to vpn.

Things done

This pull request does the following three things:

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

See also #93478 regarding the naming

@offlinehacker
Copy link
Contributor Author

@GrahamcOfBorg build protonvpn-linux-gui

@offlinehacker
Copy link
Contributor Author

CC @privateseabass

@ofborg ofborg bot requested a review from jtcoolen July 19, 2020 14:31
@CloudArtAdmins
Copy link
Contributor

#93478
Personally, I'd just do this.
I don't know the reason people would still be using the original cli.

@offlinehacker
Copy link
Contributor Author

Updated according to: #93478

@offlinehacker offlinehacker changed the title protonvpn-linux-gui: init at 2.1.1 protonvpn-gui: init at 2.1.1 Jul 20, 2020
@offlinehacker
Copy link
Contributor Author

I left the naming of the package as protonvpn-linux-cli and protonvpn-linux-gui regardless the attribute name is now protonvpn-cli and protonvpn-gui. These attributes can point to different derivations on different platforms, so in general having shorter names should be fine.

@ofborg ofborg bot requested a review from jtcoolen July 20, 2020 08:46
@offlinehacker offlinehacker merged commit 5e6bc32 into NixOS:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcoolen jtcoolen jtcoolen approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @CloudArtAdmins @jtcoolen