Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edukai: init at 4.0/edusong: init at 1.0/eduli: init at 3.0 #93232

Merged
merged 3 commits into from Aug 1, 2020
Merged

edukai: init at 4.0/edusong: init at 1.0/eduli: init at 3.0 #93232

merged 3 commits into from Aug 1, 2020

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jul 16, 2020 •
edited

Motivation for this change

These fonts are distributed by the Ministry of Education, Republic of China (Taiwan) under CC BY-ND 3.0.

The MOE Standard Kai Font (教育部標準楷書字形檔) and the MOE Standard Song Font (教育部標準宋體字形檔) follow the standard ("國字標準字體研訂原則") of the Ministry of Education in Taiwan. They would be useful in test sheets, especially when the commercial DFKai-SB (標楷體) is not available.

The MOE Li Font (教育部隸書字形檔) is a piece of font of clerical script (an archaic style of Chinese calligraphy). If merged, it would probably become the first clerical font in nixpkgs.

I join them into one PR to avoid conflicts in all-packages.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (No execution files)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (No document change needed)
  • Fits CONTRIBUTING.md.

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jul 16, 2020 •
edited

/marvin opt-in

@ShamrockLee ShamrockLee force-pushed the edukai branch 2 times, most recently from a10c1f7 to b1404d1 Compare July 16, 2020 17:17
@ShamrockLee ShamrockLee changed the title edukai: Init at 4.0 edukai: init at 4.0/edusong: init at 1.0/eduli: init at 3.0 Jul 28, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/233

@ShamrockLee
Copy link
Contributor Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 30, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ShamrockLee
Copy link
Contributor Author

/status needs_reviewer

@infinisil
Copy link
Member

Trying to connect to a homepage of the packages I get

Secure Connection Failed

An error occurred during a connection to language.moe.gov.tw. Cannot communicate securely with peer: no common encryption algorithm(s).

Error code: SSL_ERROR_NO_CYPHER_OVERLAP

So I propose to use HTTP instead of HTTPS for these links instead (both for the homepage and the download URL)

infinisil
infinisil requested changes Jul 30, 2020
View reviewed changes
pkgs/data/fonts/edukai/default.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/guidelines-on-packaging-fonts/7683/4

@ShamrockLee
Copy link
Contributor Author

/status awaiting_reviewer

@infinisil
Copy link
Member

See also #93232 (comment)

@ShamrockLee
edukai: Init at 4.0
4102707 
Add `edukai` (MOE Standard Kai Font) version 4.0
If approved, users will be able to install
the Standard Chinese Kai Font provided by
the Ministry of Education, Republic of China (Taiwan).
@ShamrockLee
edusong: Init at 1.0
8ca4992 
Add `edusong` (MOE Standard Song Font)
If approved, users will be able to install
the Standard Chinese Song Font provided by
the Ministry of Education, Republic of China (Taiwan).
@ShamrockLee
eduli: Init at 3.0
b2872b9 
Add `eduli` (MOE Li Font)
If approved, users will be able to install
the Chinese Li (clerical) Font provided by
the Ministry of Education, Republic of China (Taiwan).
This is probably the first font of clerical script in nixpkgs.
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Aug 1, 2020 •
edited

See also #93232 (comment)

Oops! Thanks for reminding.
@infinisil I have them corrected.

infinisil
infinisil approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@infinisil infinisil merged commit f9c2da7 into NixOS:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShamrockLee @nixos-discourse @infinisil