Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: fix darwin build by linking against libzstd_static #93203

Merged
merged 1 commit into from Jul 16, 2020
Merged

arrow-cpp: fix darwin build by linking against libzstd_static #93203

merged 1 commit into from Jul 16, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 15, 2020

Motivation for this change

Closes: #93202

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
arrow-cpp: fix darwin build by linking against libzstd_static
4ae8a49 
The enableShared=false override will need to be reverted on staging.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 15, 2020
@veprbl
Copy link
Member Author

veprbl commented Jul 15, 2020

@GrahamcOfBorg build arrow-cpp
@GrahamcOfBorg build python37Packages.pyarrow
@GrahamcOfBorg build python38Packages.pyarrow

@ofborg ofborg bot requested a review from tobim July 15, 2020 23:57
@veprbl veprbl merged commit 992db90 into NixOS:master Jul 16, 2020
@veprbl veprbl deleted the pr/arrow-cpp_zstd_link_static branch July 16, 2020 02:15
veprbl added a commit that referenced this pull request Jul 16, 2020
@veprbl
arrow-cpp: fix eval, enable linking against zstd_shared
166a71a 
This is a second part for #93203.
@veprbl veprbl restored the pr/arrow-cpp_zstd_link_static branch December 1, 2020 16:56
@veprbl veprbl deleted the pr/arrow-cpp_zstd_link_static branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim Awaiting requested review from tobim

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arrow-cpp fails to build or install on Darwin
1 participant
@veprbl