Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm-runtime-ext: init at 3.5.1 #93193

Merged
merged 1 commit into from Jul 16, 2020
Merged

rocm-runtime-ext: init at 3.5.1 #93193

merged 1 commit into from Jul 16, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

This package provides the closed-source extension for rocm-runtime that is necessary for OpenCL image processing.

E.g.:

❯ `nix-build --no-out-link -A clinfo`/bin/clinfo | grep Image
  Image support                                   No
❯ export OCL_ICD_VENDORS=`nix-build --no-out-link -A rocm-opencl-icd`/etc/OpenCL/vendors/ 
❯ export ROCR_EXT_DIR=`nix-build --no-out-link -A rocm-runtime-ext`/lib 
 `nix-build --no-out-link -A clinfo`/bin/clinfo | grep Image
  Image support                                   Yes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested review from acowley and Flakebi July 15, 2020 18:47
@danieldk
Copy link
Contributor Author

danieldk commented Jul 16, 2020 •
edited

I have update this PR so that rocm-runtime-ext will be picked up by either setting ROCR_EXT_DIR (as before) or adding rocm-runtime-ext to hardware.opengl.extraPackages.

@danieldk
rocm-runtime-ext: init at 3.5.1
68fecda 
This package provides the closed-source extension for rocm-runtime
that is necessary for OpenCL image processing.
Flakebi
Flakebi approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clinfo shows that images are supported for me.

One thing I am still thinking about is documentation (looking at my old PR again, I see you were the one to suggest that). I guess it would be nice to have some instructions in the manual or wiki (or both?) about how to use OpenCL, install different vulkan drivers and force using a specific driver with icd environment variables. Maybe short tests like glxinfo, clinfo and vulkaninfo also deserve a mention. Anything more?

@danieldk
Copy link
Contributor Author

@Flakebi thanks for the review!

One thing I am still thinking about is documentation (looking at my old PR again, I see you were the one to suggest that). I guess it would be nice to have some instructions in the manual or wiki (or both?) about how to use OpenCL, install different vulkan drivers and force using a specific driver with icd environment variables. Maybe short tests like glxinfo, clinfo and vulkaninfo also deserve a mention. Anything more?

I was planning to do a PR for the NixOS manual next. I guess each section should have an introduction how to test support (mentioning clinfo, vulkaninfo and glxinfo) and the have subsections for the different vendors. The NixOS manual has an X11 section, but that doesn't seem like the best place to put this information (because Wayland), so maybe some new umbrella section (GPU acceleration?). I guess instructions about VA-API etc. could go there as well.

@danieldk danieldk merged commit 2b6a6c2 into NixOS:master Jul 16, 2020
@danieldk danieldk deleted the rocm-runtime-ext branch July 16, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@acowley acowley Awaiting requested review from acowley

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @Flakebi