Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darktable: fix OpenCL support #93281

Merged
merged 1 commit into from Jul 17, 2020
Merged

darktable: fix OpenCL support #93281

merged 1 commit into from Jul 17, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

The OpenCL compiler does not properly support -I flags to include the
kernel paths, breaking relative includes. Simply replace the included
files by absolute paths.

OpenCL kernels verified to compile and work on an RX 580.

Credits for the fix go to nixos-rocm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
darktable: fix OpenCL support
0aef146 
The OpenCL compiler does not properly support -I flags to include the
kernel paths, breaking relative includes. Simply replace the included
files by absolute paths.

OpenCL kernels verified to compile and work on an RX 580.

Credits for the fix go to nixos-rocm.
mrVanDalo
mrVanDalo approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@mrVanDalo mrVanDalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@danieldk danieldk merged commit b5e5800 into NixOS:master Jul 17, 2020
@danieldk danieldk deleted the darktable-opencl branch July 17, 2020 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrVanDalo mrVanDalo mrVanDalo approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@flosse flosse Awaiting requested review from flosse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @mrVanDalo