Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad: add 0.12, multi-version support #93197

Merged
merged 2 commits into from Aug 13, 2020

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes commented Jul 15, 2020

Motivation for this change

This commit adds Nomad 0.12 to nixpkgs, but introduces it as an
additional version that is available for install, while keeping 0.11 as
the default.

The reason for introducing it as a seperate version track is that it can
be dangerous to update to early versions of HashiCorp software, and this
allows users to gradually update their Server/Client nodes as required.

My plan for version support is Last 0.x, Current 0.y, and Beta 0.z, with
the nomad tag updating to current when the current release reaches
some level of stability (around 0.y.2-3 or so).

This is my first time with a contribution that is outside of
adding/updating modules/packages, so let me know if this should have a
different commit structure.

Thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes endocrimes mentioned this pull request Aug 10, 2020
10 tasks
adds multiversion support, defaults to 0.11
as per request in PR comments, used generic.nix with version files
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @danieldk

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@danieldk danieldk merged commit d0dd12c into NixOS:master Aug 13, 2020
@endocrimes endocrimes deleted the dani/nomad-multiversoin branch August 17, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants