Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimplugins: add localvimrc, golden-ratio, and vim-rails #93251

Merged
merged 3 commits into from Aug 5, 2020

Conversation

pseudomuto
Copy link
Contributor

Motivation for this change

Update vimPlugins to include the following packages:

Things done

Added packages with the following command:

GITHUB_API_TOKEN=<REDACTED> ./update.py \
  --add "embear/vim-localvimrc" \
  --add "roman/golden-ratio" \
  --add "tpope/vim-rails"
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pseudomuto
Copy link
Contributor Author

Rebased to handle conflicts

@pseudomuto
Copy link
Contributor Author

@jonringer I've rebased this now that #93686 has been merged and I could run ./update.py.

Comment on lines 98 to 99
embear/vim-localvimrc
embear/vim-localvimrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was already added, please drop commit
git rebase -i makes this easy

@pseudomuto
Copy link
Contributor Author

Removed localvimrc plugin from this PR since it's been added already

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why ofborg is failing to eval
LGTM

https://github.com/NixOS/nixpkgs/pull/93251
37 packages built:
vimPlugins.Tagbar vimPlugins.airline vimPlugins.ale vimPlugins.calendar vimPlugins.coc-fzf vimPlugins.coc-spell-checker vimPlugins.completion-nvim vimPlugins.conjure vimPlugins.cpsm vimPlugins.defx-icons vimPlugins.denite vimPlugins.fugitive vimPlugins.git-messenger-vim vimPlugins.golden-ratio vimPlugins.julia-vim vimPlugins.lexima-vim vimPlugins.lightline-bufferline vimPlugins.ncm2-neosnippet vimPlugins.neoformat vimPlugins.neosnippet vimPlugins.neuron-vim vimPlugins.nvim-treesitter vimPlugins.quick-scope vimPlugins.table-mode vimPlugins.vim-bufkill vimPlugins.vim-eunuch vimPlugins.vim-floaterm vimPlugins.vim-plug vimPlugins.vim-ps1 vimPlugins.vim-rails vimPlugins.vim-ruby vimPlugins.vim-snippets vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-vsnip vimPlugins.vimtex vimPlugins.vista-vim

@jonringer jonringer merged commit 7220de1 into NixOS:master Aug 5, 2020
@pseudomuto pseudomuto deleted the vimplugins branch August 5, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants