Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audacious: 3.9 -> 4.0.5 #93240

Merged
merged 1 commit into from Jul 17, 2020
Merged

audacious: 3.9 -> 4.0.5 #93240

merged 1 commit into from Jul 17, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Jul 16, 2020

Motivation for this change

New upstream version.

Since version 4.0.0, the Qt version is the default. Development of the GTK version seems to have ceased: "new features will only be added to the Qt UI going forward". I've therefore combined the audacious and audaciousQt5 packages, so that we only have audacious with Qt.

I've also looked over the dependencies and made sure that we have all necessary dependencies for the plugins. I've added libcdio-paranoia for CD audio, and openmpt123 for OpenMPT (no idea what that is though).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and ttuegel July 16, 2020 10:02
@dasj19
Copy link
Contributor

dasj19 commented Jul 16, 2020

Tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93240". Runs fine. You may thick the 3rd checkbox in the PR body. The git diff looks fine as well.

@gebner gebner merged commit fd726a9 into NixOS:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @dasj19