Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google-api-core #93231

Closed
wants to merge 3 commits into from
Closed

Update google-api-core #93231

wants to merge 3 commits into from

Conversation

wesleybowman
Copy link

@wesleybowman wesleybowman commented Jul 16, 2020 •
edited

Motivation for this change

Update the python library google-api-core to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wesleybowman wesleybowman marked this pull request as ready for review July 16, 2020 07:30
@wesleybowman wesleybowman changed the title Update google Update google-api-core Jul 16, 2020
prusnak
prusnak reviewed Jul 16, 2020
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -5308,7 +5308,7 @@ in {
protobuf = callPackage ../development/python-modules/protobuf {
disabled = isPyPy;
doCheck = !isPy3k;
protobuf = pkgs.protobuf3_8;
protobuf = pkgs.protobuf3_12;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #91446 for the protobuf version discussion.

@prusnak prusnak mentioned this pull request Jul 16, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

please address conflicts

@wesleybowman
Copy link
Author

@jonringer Done!

@jonringer
Copy link
Contributor

unfortunately, we already have more up-to-date versions in staging:

/nix/store/43i4y6jnqg2rkilic1wmbc9cm6sn95jy-python3.8-google-api-core-1.22.1
[09:40:41] jon@jon-desktop /home/jon/projects/nixpkgs (python-unstable)
$ nix-build -A python3Packages.google_auth
/nix/store/q2s0kw1h5d45n1myyfwnvkr3h5i6m2vs-python3.8-google-auth-1.20.1
[09:40:51] jon@jon-desktop /home/jon/projects/nixpkgs (python-unstable)
$

this will make their way to master in ~2 weeks

@wesleybowman
Copy link
Author

@jonringer Ah, nice! I think we can close this PR then.

@wesleybowman wesleybowman deleted the update_google branch August 18, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wesleybowman @jonringer @prusnak @Janik-Haag