Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/kubernetes: Don't re-import <nixpkgs> #93228

Merged
merged 1 commit into from Jul 16, 2020
Merged

nixos/tests/kubernetes: Don't re-import <nixpkgs> #93228

merged 1 commit into from Jul 16, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 16, 2020

Unnecessary (impure) import was causing ofborg to be unable to test kubernetes. I think this fixes it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

@ofborg test kubernetes.rbac.singlenode kubernetec.rbac.multinode kubernetes.dns.singlenode kubernetes.dns.multinode

@srhb srhb marked this pull request as draft July 16, 2020 06:49
@srhb
Copy link
Contributor Author

srhb commented Jul 16, 2020

Ah, typo.

@ofborg test kubernetes.rbac.multinode

@srhb srhb marked this pull request as ready for review July 16, 2020 06:58
@srhb srhb requested a review from saschagrunert July 16, 2020 06:59
@srhb srhb mentioned this pull request Jul 16, 2020
Merged
10 tasks
saschagrunert
saschagrunert approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srhb srhb merged commit 45f4bde into NixOS:master Jul 16, 2020
@srhb srhb deleted the kubernetes-fixup-test branch July 16, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @saschagrunert