Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.numexpr: fix darwin build by refactoring checkPhase #93208

Merged
merged 1 commit into from Jul 18, 2020
Merged

pythonPackages.numexpr: fix darwin build by refactoring checkPhase #93208

merged 1 commit into from Jul 18, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 16, 2020

This fixes a following error on python 3.8:

FileNotFoundError: [Errno 2] No such file or directory: '/nix/store/0s7kw66pav5c7bi38lb0gznxnxz31a1n-python3.8-numexpr-2.7.1/'

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
pythonPackages.numexpr: fix darwin build by refactoring checkPhase
c184c87 
This fixes a following error on python 3.8:

FileNotFoundError: [Errno 2] No such file or directory: '/nix/store/0s7kw66pav5c7bi38lb0gznxnxz31a1n-python3.8-numexpr-2.7.1/<stdin>'
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 16, 2020
@veprbl
Copy link
Member Author

veprbl commented Jul 16, 2020

@GrahamcOfBorg build python27Packages.numexpr
@GrahamcOfBorg build python37Packages.numexpr
@GrahamcOfBorg build python38Packages.numexpr

@veprbl veprbl merged commit 012582c into NixOS:master Jul 18, 2020
@veprbl veprbl deleted the pr/numexpr_darwin_fix branch July 18, 2020 16:05
@veprbl veprbl restored the pr/numexpr_darwin_fix branch December 1, 2020 16:47
@veprbl veprbl deleted the pr/numexpr_darwin_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl